react-code-quality-reviewer-prompt

# React Code Quality Reviewer Prompt Template

## Overview

Prompt template for dispatching a React code quality review subagent. Core principle: verify that React code is well-built (clean, tested, maintainable) with special focus on test quality — tests should catch real bugs, not verify DOM structure or mock calls.

## When to Use

- After a React implementation task is complete and you need a quality-focused code review
- When you want to validate test quality beyond basic coverage (behavioral testing, structure, mock boundaries)
- As the second review pass in a two-pass workflow: spec compliance first, then code quality

## When NOT to Use

- For non-React code — the checklist is React/Vitest/RTL-specific
- As the first review of a task — run a spec compliance review first to confirm requirements are met
- For general architecture or design reviews without implementation code to inspect

## Required Dependency

**REQUIRED PLUGIN:** `superpowers` — provides `code-reviewer` agent and `requesting-code-review/code-reviewer.md` base template.

The base template handles: git diff inspection, standard review checklist (code quality, architecture, testing, requirements, production readiness), and output format (Strengths, Issues by severity, Recommendations, Assessment with merge verdict). This skill adds React test quality criteria via `ADDITIONAL_REVIEW_CRITERIA`.

## Placeholder Variables

| Variable | Source |
|---|---|
| `WHAT_WAS_IMPLEMENTED` | From implementer subagent's completion report |
| `PLAN_OR_REQUIREMENTS` | Plan file path + task number, e.g. "Task 3 from docs/plans/feature-x.md" |
| `BASE_SHA` | Commit SHA before implementation (`git log`) |
| `HEAD_SHA` | Current commit after implementation (typically `HEAD`) |
| `DESCRIPTION` | One-line task summary |

## Common Mistakes

- **Dispatching before spec compliance review** — run spec review first (via `superpowers:requesting-code-review` without React checklist). This skill checks *how* it was built, not