code-quality

# Code Quality Skill

Code review, test generation, and quality assurance patterns.

## Quick Reference

| Area | Key Patterns | When to Use |
|------|--------------|-------------|
| **Review** | Security, quality, maintainability | After code changes |
| **Improve** | Systematic analysis, refactoring | Code optimization |
| **Test** | Unit, integration, edge cases | Test creation |

---

## Code Review

### Approach
1. Run git diff to see recent changes
2. Focus on modified files
3. Begin review immediately

### Review Checklist

| Category | Checks |
|----------|--------|
| **Readability** | Simple, well-named, no duplication |
| **Correctness** | Proper error handling, edge cases |
| **Security** | No secrets, input validation |
| **Performance** | Efficient algorithms, no N+1 |
| **Testing** | Good coverage, meaningful tests |

### Feedback Organization

**Critical** (must fix):
- Security vulnerabilities
- Data loss risks
- Breaking bugs

**Warnings** (should fix):
- Performance issues
- Maintainability concerns
- Missing tests

**Suggestions** (consider):
- Style improvements
- Alternative approaches
- Documentation additions

### Review Template

```markdown
## Code Review: [PR/commit]

### Summary
[Brief overview of changes]

### Critical Issues
1. **[Issue]** - [File:line]
   - Problem: [Description]
   - Fix: [How to fix]

### Warnings
1. **[Issue]** - [File:line]
   - Problem: [Description]
   - Suggestion: [How to improve]

### Suggestions
1. **[Suggestion]** - [File:line]
   - [Optional improvement]

### Positive Notes
- [What's done well]
```

---

## Systematic Code Improvement

### Analysis Dimensions

| Dimension | Checks |
|-----------|--------|
| **Correctness** | Logic bugs, edge cases, error handling |
| **Maintainability** | Complexity, coupling, naming |
| **Security** | OWASP Top 10, input validation |
| **Performance** | Algorithms, memory, I/O |

### Complexity Metrics

| Metric | Good | Warning | Bad |
|--------|------|---------|-----|
| C